Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 18B691992F for ; Thu, 28 Apr 2016 16:48:13 +0000 (UTC) Received: (qmail 41029 invoked by uid 500); 28 Apr 2016 16:48:13 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 40997 invoked by uid 500); 28 Apr 2016 16:48:13 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 40949 invoked by uid 99); 28 Apr 2016 16:48:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 16:48:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D684D2C1F5D for ; Thu, 28 Apr 2016 16:48:12 +0000 (UTC) Date: Thu, 28 Apr 2016 16:48:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-3786) Add BigDecimal and BigInteger as Basic types MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262491#comment-15262491 ] ASF GitHub Bot commented on FLINK-3786: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/1928#discussion_r61461901 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigIntComparator.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.typeutils.base; + +import java.io.IOException; +import java.math.BigInteger; +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.MemorySegment; + +@Internal +public final class BigIntComparator extends BasicTypeComparator { + + private static final long serialVersionUID = 1L; + + public BigIntComparator(boolean ascending) { + super(ascending); + } + + @Override + public int compareSerialized(DataInputView firstSource, DataInputView secondSource) throws IOException { + BigInteger bi1 = BigIntSerializer.readBigInteger(firstSource); + BigInteger bi2 = BigIntSerializer.readBigInteger(secondSource); + int comp = bi1.compareTo(bi2); + return ascendingComparison ? comp : -comp; + } + + @Override + public boolean supportsNormalizedKey() { + return true; + } + + @Override + public boolean supportsSerializationWithKeyNormalization() { + return false; + } + + @Override + public int getNormalizeKeyLen() { + return Integer.MAX_VALUE; + } + + @Override + public boolean isNormalizedKeyPrefixOnly(int keyBytes) { + return true; + } + + /** + * Adds a normalized key containing the normalized number of bits and MSBs of the given record. + * 1 bit determines the sign (negative, zero/positive), 31 bit the bit length of the record. + * Remaining bytes contain the most significant bits of the record. + */ + @Override + public void putNormalizedKey(BigInteger record, MemorySegment target, int offset, int len) { + // add normalized bit length (the larger the length, the larger the value) + int bitLen = 0; + if (len > 0) { + final int signum = record.signum(); + bitLen = record.bitLength(); + + // normalize dependent on sign + // from 0 to Integer.MAX + // OR from Integer.MAX to 0 + int normBitLen = signum < 0 ? Integer.MAX_VALUE - bitLen : bitLen; + + // add sign + if (signum >= 0) { + normBitLen |= (1 << 31); + } + + for (int i = 0; i < 4 && len > 0; i++, len--) { + target.put(offset++, (byte) (normBitLen >>> (8 * (3 - i)))); + } + } + + // fill remaining bytes with most significant bits + for (; len > 0; len--) { + byte b = 0; + for (int bytePos = 0; bytePos < 8 && bytePos < bitLen; bytePos++) { --- End diff -- I think I cannot add test data that brings the test to fail. Equality is always accepted by the ComparatorTestBase. E.g. returning a constant byte is also always true. > Add BigDecimal and BigInteger as Basic types > -------------------------------------------- > > Key: FLINK-3786 > URL: https://issues.apache.org/jira/browse/FLINK-3786 > Project: Flink > Issue Type: New Feature > Components: Core > Reporter: Timo Walther > Assignee: Timo Walther > > We already had the discussion on the mailing list some months ago about adding BigDecimal and BigInteger as basic types. > Especially for business or scientific applications it > makes sense to support the BigInteger and BigDecimal types natively. In > my opinion they are as important as Date or Void and should be added as > BasicTypes. The Table API would also benefit from it. > http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3C564CAD71.8070001@apache.org%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)