Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F31D319C35 for ; Thu, 14 Apr 2016 14:54:26 +0000 (UTC) Received: (qmail 66992 invoked by uid 500); 14 Apr 2016 14:54:26 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 66915 invoked by uid 500); 14 Apr 2016 14:54:26 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 66837 invoked by uid 99); 14 Apr 2016 14:54:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2016 14:54:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B494C2C1F62 for ; Thu, 14 Apr 2016 14:54:25 +0000 (UTC) Date: Thu, 14 Apr 2016 14:54:25 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-3749) Improve decimal handling MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241308#comment-15241308 ] ASF GitHub Bot commented on FLINK-3749: --------------------------------------- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1881#issuecomment-209985156 I don't think we should handle `DECIMAL` as `double`. `DECIMAL` provides fixed precision in contrast to `double`. If we internally represent `DECIMAL` as `double` precision is not guaranteed. I think we need a special data type, serializers, and also custom math logic to handle `DECIMAL` correctly. Maybe Calcite offers some of that? > Improve decimal handling > ------------------------ > > Key: FLINK-3749 > URL: https://issues.apache.org/jira/browse/FLINK-3749 > Project: Flink > Issue Type: Bug > Components: Table API > Reporter: Timo Walther > Assignee: Timo Walther > > The current decimal handling is too restrictive and does not allow literals such as "11.2". -- This message was sent by Atlassian JIRA (v6.3.4#6332)