Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 12 Apr 2016 16:48:25 +0000 (UTC)
From: "GaoLun (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12957746.1460390878000.208223.1460479705465@Atlassian.JIRA>
In-Reply-To: <JIRA.12957746.1460390878000@Atlassian.JIRA>
References: <JIRA.12957746.1460390878000@Atlassian.JIRA>
 <JIRA.12957746.1460390878150@arcas>
Subject: [jira] [Commented] (FLINK-3729) Several SQL tests fail on Windows
 OS
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237523#comment-15237523 ] 

GaoLun commented on FLINK-3729:
-------------------------------

The problem is the {{ast}} would use \r\n in Windows environment. The {{ast}} is created by {{RelOptUtil.toString(relNode)}} which would use different line-endings depend on the OS. And we can solve this issue as you mentioned:
1: modify the ast 
{code}
val ast = RelOptUtil.toString(relNode).replaceAll("\r\n", "\n")
{code}
2: For every test file, add another one with Windows version.

> Several SQL tests fail on Windows OS
> ------------------------------------
>
>                 Key: FLINK-3729
>                 URL: https://issues.apache.org/jira/browse/FLINK-3729
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API
>    Affects Versions: 1.0.1
>            Reporter: Chesnay Schepler
>
> The Table API SqlExplain(Test/ITCase) fail categorically on Windows due to different line-endings. These tests generate an string representation of an abstract syntax tree; problem is there is a difference in line-endings.
> The expected ones contain LF, the actual one CRLF.
> The tests should be either changed to either
> * include CRLF line-endings in the expected string when run on windows
> * always use LF line-endings regardless of OS
> * use a compare method that is aware of this issue.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)