Return-Path: 
 <issues-return-52792-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D2CF31948B
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Wed, 27 Apr 2016 13:14:13 +0000 (UTC)
Received: (qmail 32184 invoked by uid 500); 27 Apr 2016 13:14:13 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 31894 invoked by uid 500); 27 Apr 2016 13:14:13 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 31608 invoked by uid 99); 27 Apr 2016 13:14:13 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Apr 2016 13:14:13 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 2BE182C1F6D
	for <issues@flink.apache.org>; Wed, 27 Apr 2016 13:14:13 +0000 (UTC)
Date: Wed, 27 Apr 2016 13:14:13 +0000 (UTC)
From: "Till Rohrmann (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12940263.1455824950000.46354.1461762853177@Atlassian.JIRA>
In-Reply-To: <JIRA.12940263.1455824950000@Atlassian.JIRA>
References: <JIRA.12940263.1455824950000@Atlassian.JIRA>
 <JIRA.12940263.1455824950614@arcas>
Subject: [jira] [Commented] (FLINK-3444) env.fromElements relies on the
 first input element for determining the DataSet/DataStream type
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260115#comment-15260115 ] 

Till Rohrmann commented on FLINK-3444:
--------------------------------------

I'm wondering why the above described problem was solved by introducing an overloaded method {{fromElements}} which takes as the first parameter the {{Class<T>}} of the elements? The problem is that if you do something like {{env.fromElements(SubClass.class, new ParentClass())}} then the vararg only variant of {{fromElements}} will be called with type {{Object}} as result (since Object is the super type of {{Class<SubClass>}} and {{ParentClass}}. The reason is that {{ParentClass}} is not a subtype of {{SubClass}} and thus the new {{fromElements}} method is not applicable.

Wouldn't it have been better to automatically infer the super type of all given elements? Usually the {{fromElements}} method is only called for very few elements and, thus, it should be feasible to iterate over all elements to extract the common super type. 

> env.fromElements relies on the first input element for determining the DataSet/DataStream type
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-3444
>                 URL: https://issues.apache.org/jira/browse/FLINK-3444
>             Project: Flink
>          Issue Type: Bug
>          Components: DataSet API, DataStream API
>    Affects Versions: 0.10.0, 1.0.0
>            Reporter: Vasia Kalavri
>             Fix For: 1.1.0
>
>
> The {{fromElements}} method of the {{ExecutionEnvironment}} and {{StreamExecutionEnvironment}} determines the DataSet/DataStream type by extracting the type of the first input element.
> This is problematic if the first element is a subtype of another element in the collection.
> For example, the following
> {code}
> DataStream<Event> input = env.fromElements(new Event(1, "a"), new SubEvent(2, "b"));
> {code}
> succeeds, while the following
> {code}
> DataStream<Event> input = env.fromElements(new SubEvent(1, "a"), new Event(2, "b"));
> {code}
> fails with "java.lang.IllegalArgumentException: The elements in the collection are not all subclasses of SubEvent".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)