Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: vasia <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1939-flink@git.apache.org>
In-Reply-To: <git-pr-1939-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2828] [tableAPI] Add TableSource
 interf...
Content-Type: text/plain
Message-Id: <20160426151441.D295CDFE5F@git1-us-west.apache.org>
Date: Tue, 26 Apr 2016 15:14:41 +0000 (UTC)

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1939#discussion_r61104611
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchTableSourceScanRule.scala ---
    @@ -0,0 +1,71 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.table.plan.rules.dataSet
    +
    +import org.apache.calcite.plan.{Convention, RelOptRule, RelOptRuleCall, RelTraitSet}
    +import org.apache.calcite.rel.RelNode
    +import org.apache.calcite.rel.convert.ConverterRule
    +import org.apache.calcite.rel.core.TableScan
    +import org.apache.calcite.rel.logical.LogicalTableScan
    +import org.apache.flink.api.table.plan.nodes.dataset.{BatchTableSourceScan, DataSetConvention}
    +import org.apache.flink.api.table.plan.schema.TableSourceTable
    +import org.apache.flink.api.table.sources.BatchTableSource
    +
    +/** Rule to convert a [[LogicalTableScan]] into a [[BatchTableSourceScan]]. */
    +class BatchTableSourceScanRule
    +  extends ConverterRule(
    +      classOf[LogicalTableScan],
    +      Convention.NONE,
    +      DataSetConvention.INSTANCE,
    +      "BatchTableSourceScanRule")
    +  {
    +
    +  /** Rule must only match if TableScan targets a [[BatchTableSource]] */
    --- End diff --
    
    Could merge this rule with `DataSetScanRule`, so that if we have a `TableSourceTable ` convert to `BatchTableSourceScan ` and if we have a `DataSetTable` convert to `DataSetSource`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---