Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1926-flink@git.apache.org>
In-Reply-To: <git-pr-1926-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API
Content-Type: text/plain
Message-Id: <20160425151136.8E662DFDE3@git1-us-west.apache.org>
Date: Mon, 25 Apr 2016 15:11:36 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1926#discussion_r60929903
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala ---
    @@ -0,0 +1,121 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.scala.table.test
    +
    +import org.apache.flink.api.java.tuple.Tuple
    +import org.apache.flink.api.scala.table._
    +import org.apache.flink.api.scala.{ExecutionEnvironment, _}
    +import org.apache.flink.api.table.{Row, TableEnvironment}
    +import org.apache.flink.api.table.test.utils.TableProgramsTestBase
    +import org.apache.flink.api.table.test.utils.TableProgramsTestBase.TableConfigMode
    +import org.apache.flink.test.util.MultipleProgramsTestBase.TestExecutionMode
    +import org.apache.flink.test.util.TestBaseUtils
    +import org.junit._
    +import org.junit.runner.RunWith
    +import org.junit.runners.Parameterized
    +
    +import scala.collection.JavaConverters._
    +
    +@RunWith(classOf[Parameterized])
    +class SortITCase(
    +    mode: TestExecutionMode,
    +    configMode: TableConfigMode)
    +  extends TableProgramsTestBase(mode, configMode) {
    +
    +  @Test
    +  def testOrderByDesc(): Unit = {
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +    
    +    val t = env.fromElements((1, "First"), (3, "Third"), (2, "Second")).toTable(tEnv)
    +      .orderBy('_1.desc)
    +
    +    val expected = "3,Third\n2,Second\n1,First"
    +    val results = t.toDataSet[Row].setParallelism(1).collect()
    +    compareOrderedResultAsText(expected, results)
    +  }
    +
    +  @Test
    +  def testOrderByAsc(): Unit = {
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +    
    +    val t = env.fromElements((1, "First"), (3, "Third"), (2, "Second")).toTable(tEnv)
    +      .orderBy('_1.asc)
    +
    +    val expected = "1,First\n2,Second\n3,Third"
    +    val results = t.toDataSet[Row].setParallelism(1).collect()
    +    compareOrderedResultAsText(expected, results)
    +  }
    +
    +  @Test
    +  def testOrderByMultipleFieldsDifferentDirections(): Unit = {
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +    
    +    env.setParallelism(2)
    +    val t = env.fromElements((1, 3, "Third"), (1, 2, "Fourth"), (1, 4, "Second"),
    +      (2, 1, "Sixth"), (1, 5, "First"), (1, 1, "Fifth"))
    +      .toTable(tEnv).orderBy('_1.asc, '_2.desc)
    +
    +    val expected = "1,5,First\n1,4,Second\n1,3,Third\n1,2,Fourth\n1,1,Fifth\n2,1,Sixth"
    +    val results = t.toDataSet[Row].mapPartition(rows => Seq(rows.toSeq)).collect()
    +
    +    implicit def rowOrdering = Ordering.by((x : Row) => (x.productElement(0).asInstanceOf[Int],
    --- End diff --
    
    Can you change the `Ordering` such that is does not rely on the actual data (a value (2, 20, "Seventh") would not be sorted correctly).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---