Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: uce <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1910-flink@git.apache.org>
In-Reply-To: <git-pr-1910-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-3230] Add producer for Amazon
 Kinesis S...
Content-Type: text/plain
Message-Id: <20160419100344.7E268DFBC6@git1-us-west.apache.org>
Date: Tue, 19 Apr 2016 10:03:44 +0000 (UTC)

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1910#discussion_r60204277
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/KinesisSerializationSchema.java ---
    @@ -0,0 +1,45 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.kinesis;
    +
    +
    +import java.io.Serializable;
    +import java.nio.ByteBuffer;
    +
    +/**
    + * Kinesis-specific serialization schema, allowing users to specify a target stream based
    + * on a record's contents.
    + * @param <T>
    + */
    +public interface KinesisSerializationSchema<T> extends Serializable {
    +	/**
    +	 * Serialize the given element into a ByteBuffer
    +	 *
    +	 * @param element The element to serialize
    +	 * @return Serialized representation of the element
    +	 */
    +	ByteBuffer serialize(T element);
    +
    +	/**
    +	 * Optional method to determine the target stream based on the element.
    +	 * Return "null" to use the default stream
    --- End diff --
    
    Do you mean to return the String `"null"` or `<code>null</code>`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---