flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yjshen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...
Date Wed, 20 Apr 2016 14:42:41 GMT
GitHub user yjshen opened a pull request:

    https://github.com/apache/flink/pull/1916

    [FLINK-3754][Table]Add a validation phase before construct RelNode using TableAPI

    This PR aims at adding an extra phase of **validation** for plans generated from Table
API, matches the functionality of Calcite's Validator that are called during we execute an
query expressed in SQL String.
    
    In order to do this, I inserted a new layer between TableAPI and `RelNode` construction:
The `Logical Plan`.
    
    And the main procedure of validation and RelNode construction work as follows:
    
    1. Constructing logical plan in flight
    2. When we are about to execute the plan:
    3. Do resolution using table/dataset/datastream schema
    4. Do validation on the type annotated logical plan tree
    5. Translate logical plan into `RelNode` once we successfully finished validation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yjshen/flink extra_validation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1916
    
----
commit 7fb102af1fa52dab2f0c80785f75bf7e0d8a7062
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-13T08:46:58Z

    make TreeNode extends Product

commit ab75d4857cb203714ee037aea2e55de776c4dd32
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-15T14:51:20Z

    wip expressions validation, should create expressions for functions next

commit 61e4bb09d754fe0aca7624e3fcd70d364e4154d3
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-16T07:02:07Z

    add functions for math and string

commit 6abbfad0a11a3874150baa4dcabf6caab37cf0be
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-18T16:49:04Z

    wip move table api on logicalNode

commit 64ecdbef273895e4527fb6b5120d92acb0d20542
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-19T05:20:47Z

    resolve and validate next

commit dc42a44cc47cdb619076074eda95b84157554337
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-19T19:26:58Z

    wip

commit c04292abe6484e095171a66c399c16e50e98870a
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-20T12:26:25Z

    fix bug in validator, merge eval, add doc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message