flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3777) Add open and close methods to manage IF lifecycle
Date Tue, 26 Apr 2016 10:43:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257885#comment-15257885
] 

ASF GitHub Bot commented on FLINK-3777:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1903#discussion_r61064734
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
    @@ -200,6 +209,7 @@ else if (!this.taskCanceled) {
     		else {
     			LOG.debug(getLogString("Data source operator cancelled"));
     		}
    +		
    --- End diff --
    
    random new empty line


> Add open and close methods to manage IF lifecycle
> -------------------------------------------------
>
>                 Key: FLINK-3777
>                 URL: https://issues.apache.org/jira/browse/FLINK-3777
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Flavio Pompermaier
>            Assignee: Flavio Pompermaier
>              Labels: inputformat, lifecycle
>
> At the moment the opening and closing of an inputFormat are not managed, although open()
could be (improperly IMHO) simulated by configure().
> This limits the possibility to reuse expensive resources (like database connections)
and manage their release. 
> Probably the best option would be to add 2 methods (i.e. openInputformat() and closeInputFormat()
) to RichInputFormat*
> * NOTE: the best option from a "semantic" point of view would be to rename the current
open() and close() to openSplit() and closeSplit() respectively while using open() and close()
methods for the IF lifecycle management, but this would cause a backward compatibility issue...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message