flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3750) Make JDBCInputFormat a parallel source
Date Thu, 14 Apr 2016 14:08:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241204#comment-15241204
] 

ASF GitHub Bot commented on FLINK-3750:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1885#discussion_r59722992
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -232,7 +255,7 @@ private void addValue(OUT reuse) throws IOException, SQLException
{
     						reuse.setField(resultSet.getInt(pos + 1), pos);
     						break;
     					case java.sql.Types.FLOAT:
    -						reuse.setField(resultSet.getDouble(pos + 1), pos);
    +						reuse.setField(resultSet.getFloat(pos + 1), pos);
    --- End diff --
    
    I'm aware of the confusion. However that is something users will have to live with; we
can't just change the data so that a user doesn't run into an exception he _should_ run into.
    
    All we can do is document the mapping and hope that people will read it.


> Make JDBCInputFormat a parallel source
> --------------------------------------
>
>                 Key: FLINK-3750
>                 URL: https://issues.apache.org/jira/browse/FLINK-3750
>             Project: Flink
>          Issue Type: Improvement
>          Components: Batch
>    Affects Versions: 1.0.1
>            Reporter: Flavio Pompermaier
>            Assignee: Flavio Pompermaier
>            Priority: Minor
>              Labels: connector, jdbc
>
> At the moment the batch JDBC InputFormat does not support parallelism (NonParallelInput).
I'd like to remove such limitation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message