flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3750) Make JDBCInputFormat a parallel source
Date Thu, 14 Apr 2016 12:44:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241063#comment-15241063
] 

ASF GitHub Bot commented on FLINK-3750:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1885#discussion_r59709766
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/RangeInputSplit.java
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.io;
    +
    +import org.apache.flink.annotation.Public;
    +import org.apache.flink.core.io.InputSplit;
    +
    +/**
    + * A range input split provides information about a particular range of keys, each with
a min and a max value. 
    + */
    +@Public
    +public class RangeInputSplit implements InputSplit{
    +
    +	private static final long serialVersionUID = 4310893817447171721L;
    +	
    +	private long min;
    +	private long max;
    +	
    +	/** The number of the split. */
    +	private final int splitNumber;
    +	
    +	public RangeInputSplit(int splitNumber, long min, long max){
    --- End diff --
    
    missing space before curly brace


> Make JDBCInputFormat a parallel source
> --------------------------------------
>
>                 Key: FLINK-3750
>                 URL: https://issues.apache.org/jira/browse/FLINK-3750
>             Project: Flink
>          Issue Type: Improvement
>          Components: Batch
>    Affects Versions: 1.0.1
>            Reporter: Flavio Pompermaier
>            Assignee: Flavio Pompermaier
>            Priority: Minor
>              Labels: connector, jdbc
>
> At the moment the batch JDBC InputFormat does not support parallelism (NonParallelInput).
I'd like to remove such limitation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message