flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3730) Fix RocksDB Local Directory Initialization
Date Tue, 12 Apr 2016 18:36:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237730#comment-15237730
] 

ASF GitHub Bot commented on FLINK-3730:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1873#issuecomment-209045705
  
    Looks good to me, +1 to merge


> Fix RocksDB Local Directory Initialization
> ------------------------------------------
>
>                 Key: FLINK-3730
>                 URL: https://issues.apache.org/jira/browse/FLINK-3730
>             Project: Flink
>          Issue Type: Bug
>          Components: state backends, Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> The test that checks whether a directory is viable is not correct and the tests in `RocksDBStateBackendConfigTest`
fail to catch them: `testFailWhenNoLocalStorageDir()` and `testContinueOnSomeDbDirectoriesMissing()`
> The problem is that the backend tests whether the dir exists or can be created. The tests
create the directory and set it to non-writable. This means that the check accepts these.
The job would only fail later when actually trying to create a directory in the initialized
data directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message