flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3708) Scala API for CEP
Date Wed, 20 Apr 2016 13:43:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249910#comment-15249910
] 

ASF GitHub Bot commented on FLINK-3708:
---------------------------------------

Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1905#issuecomment-212429457
  
    Thanks for your good contribution @StefanRRichter. I had some inline comments.
    
    It would be good to revisit the link tags in the ScalaDocs and replace them with the ScalaDoc
link syntax. I haven't marked all occurrences in the code. 
    
    Furthermore, it should be possible to completely throw out the `ClassTag` context bound.
I have only marked the first occurrences where I've noticed it.
    
    The Scala code contained several lines which exceeded the maximum line length of 100 characters.
The Scala style check plugin, which detects these style violations, is executed when you run
`mvn verify`. Thus, it is always a good idea to run `mvn verify` once locally before pushing
commits to a PR.
    
    Ping me once you've addressed my comments. Then I'll make sure that the PR is merged.


> Scala API for CEP
> -----------------
>
>                 Key: FLINK-3708
>                 URL: https://issues.apache.org/jira/browse/FLINK-3708
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Stefan Richter
>
> Currently, The CEP library does not support Scala case classes, because the {{TypeExtractor}}
cannot handle them. In order to support them, it would be necessary to offer a Scala API for
the CEP library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message