flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.
Date Tue, 19 Apr 2016 13:31:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247751#comment-15247751

ASF GitHub Bot commented on FLINK-2998:

Github user fhueske commented on the pull request:

    Hi @gallenvara, thanks for the update! I tried it locally and it worked as expected. 
    I would like two more test methods though, to ensure that the thing is working end-to-end.
    Could you add one test method to `JoinITCase` which basically extends `testeUDFJoinOnTuplesWithMultipleKeyFieldPositions()`
and uses range partitioning. For that you should provide a DataDistribution and set the parallelism
to 4 on the environment. 
    Please to the same with `CoGroupITCase.testCoGroupWithMultipleKeyFieldsWithFieldSelector()`
    After that we can merge the PR. Thanks, Fabian

> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>                 Key: FLINK-2998
>                 URL: https://issues.apache.org/jira/browse/FLINK-2998
>             Project: Flink
>          Issue Type: New Feature
>          Components: Optimizer
>            Reporter: Chengxiang Li
>            Priority: Minor
> The optimizer may have potential opportunity to optimize the DAG while it found two input
range partition are equivalent, we does not support the comparison yet.

This message was sent by Atlassian JIRA

View raw message