flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From knaufk <...@git.apache.org>
Subject [GitHub] flink pull request: Timer coalescing across keys and cleanup of un...
Date Thu, 28 Apr 2016 20:05:18 GMT
GitHub user knaufk reopened a pull request:

    https://github.com/apache/flink/pull/1944

    Timer coalescing across keys and cleanup of unused trigger tasks

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Per timestamp only one TriggerTask is registered at
    the runtime context. When the first timer is registered a new TriggerTask
    is sheduled. When no timer is registered anymore for a specific timestamp
    the corresponding trigger task is canceled and hence removed.
    
    The ScheduledFutures to cancel trigger tasks are not checkpointed. So
    cleanup of trigger tasks will not work after a failure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knaufk/flink FLINK-3669

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1944
    
----
commit e1f7a5b0c448516e7c42bfc4938755a43e3bcae0
Author: Konstantin Knauf <konstantin.knauf@tngtech.com>
Date:   2016-04-05T17:59:19Z

    Timer coalescing across keys and cleanup of unused trigger tasks
    
    Per timestamp only one TriggerTask is registered at
    the runtime context. When the first timer is registered a new TriggerTask
    is sheduled. When no timer is registered anymore for a specific timestamp
    the corresponding trigger task is canceled and hence removed.
    
    The ScheduledFutures to cancel trigger tasks are not checkpointed. So
    cleanup of trigger tasks will not work after a failure.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message