flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3786] [core] [api-extending] Add BigDec...
Date Thu, 28 Apr 2016 14:25:28 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1928#discussion_r61435703
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigIntComparator.java
---
    @@ -0,0 +1,111 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.common.typeutils.base;
    +
    +import java.io.IOException;
    +import java.math.BigInteger;
    +import org.apache.flink.annotation.Internal;
    +import org.apache.flink.core.memory.DataInputView;
    +import org.apache.flink.core.memory.MemorySegment;
    +
    +@Internal
    +public final class BigIntComparator extends BasicTypeComparator<BigInteger> {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	public BigIntComparator(boolean ascending) {
    +		super(ascending);
    +	}
    +
    +	@Override
    +	public int compareSerialized(DataInputView firstSource, DataInputView secondSource)
throws IOException {
    +		BigInteger bi1 = BigIntSerializer.readBigInteger(firstSource);
    +		BigInteger bi2 = BigIntSerializer.readBigInteger(secondSource);
    +		int comp = bi1.compareTo(bi2);
    +		return ascendingComparison ? comp : -comp;
    +	}
    +
    +	@Override
    +	public boolean supportsNormalizedKey() {
    +		return true;
    +	}
    +
    +	@Override
    +	public boolean supportsSerializationWithKeyNormalization() {
    +		return false;
    +	}
    +
    +	@Override
    +	public int getNormalizeKeyLen() {
    +		return Integer.MAX_VALUE;
    +	}
    +
    +	@Override
    +	public boolean isNormalizedKeyPrefixOnly(int keyBytes) {
    +		return true;
    +	}
    +
    +	/**
    +	 * Adds a normalized key containing the normalized number of bits and MSBs of the given
record.
    +	 * 1 bit determines the sign (negative, zero/positive), 31 bit the bit length of the
record.
    +	 * Remaining bytes contain the most significant bits of the record.
    +	 */
    +	@Override
    +	public void putNormalizedKey(BigInteger record, MemorySegment target, int offset, int
len) {
    +		// add normalized bit length (the larger the length, the larger the value)
    +		int bitLen = 0;
    +		if (len > 0) {
    +			final int signum = record.signum();
    +			bitLen = record.bitLength();
    +
    +			// normalize dependent on sign
    +			// from 0 to Integer.MAX
    +			// OR from Integer.MAX to 0
    +			int normBitLen = signum < 0 ? Integer.MAX_VALUE - bitLen : bitLen;
    +
    +			// add sign
    +			if (signum >= 0) {
    +				normBitLen |= (1 << 31);
    +			}
    +
    +			for (int i = 0; i < 4 && len > 0; i++, len--) {
    +				target.put(offset++, (byte) (normBitLen >>> (8 * (3 - i))));
    +			}
    +		}
    +
    +		// fill remaining bytes with most significant bits
    +		for (; len > 0; len--) {
    +			byte b = 0;
    +			for (int bytePos = 0; bytePos < 8 && bytePos < bitLen; bytePos++) {
    --- End diff --
    
    I think, this for loop repeatedly writes the first byte because `bytePos` is always initialized
with 0.
    We need to remember how many bytes we have written.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message