flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: Refactoring the File Monitoring Source.
Date Thu, 28 Apr 2016 10:05:51 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1929#issuecomment-215375702
  
    Thank you for the pull request. This is a much needed feature!
    
    > What's with the PR title? :confused:
    
    I agree with @zentol here! Its important to put the right JIRA id into the PR title so
that comments are properly mirrored into JIRA (this has also legal reasons. GitHub is not
an entity controlled by the ASF, so all discussions must be mirrored to some apache systems)
    
    For future pull requests, please make sure to follow the PR checklist (the JIRA reference
is the first item there!)
    https://github.com/apache/flink/blob/master/PULL_REQUEST_TEMPLATE.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message