flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3717 - Be able to re-start reading from ...
Date Mon, 25 Apr 2016 14:14:26 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/CheckpointableInputFormat.java
    @@ -0,0 +1,51 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.common.io;
    +import org.apache.flink.core.io.InputSplit;
    +import java.io.IOException;
    +import java.io.Serializable;
    --- End diff --
    We could add a comment here, something like "Extension of {@link InputFormat} that allows
checkpointing/restoring the current channel state".
    Also, I think we should make the signature match `InputFormat`, i.e.:
    `public interface CheckpointableInputFormat<OT, T extends InputSplit> extends InputFormat<OT,

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message