flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()
Date Fri, 22 Apr 2016 11:59:48 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1903#discussion_r60727958
  
    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/DataSourceNode.java
---
    @@ -150,6 +151,12 @@ protected void computeOperatorSpecificDefaultEstimates(DataStatistics
statistics
     				}
     				return;
     			}
    +			finally {
    +				// close the instantiated resources before returning
    +				if(format != null && format instanceof RichInputFormat) {
    --- End diff --
    
    If we close the IF here, we might not be able to retrieve the stats. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message