flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3708] Scala API for CEP (initial).
Date Wed, 20 Apr 2016 13:34:11 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1905#discussion_r60407197
  
    --- Diff: flink-libraries/flink-cep-scala/src/test/scala/org/apache/flink/cep/scala/CEPITCase.scala
---
    @@ -0,0 +1,258 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.cep.scala
    +
    +import java.util.{Map => JMap}
    +
    +import org.apache.flink.api.java.tuple.Tuple2
    +import org.apache.flink.cep.scala.pattern.Pattern
    +import org.apache.flink.core.fs.FileSystem
    +import org.apache.flink.streaming.api.TimeCharacteristic
    +import org.apache.flink.streaming.api.functions.AssignerWithPunctuatedWatermarks
    +import org.apache.flink.streaming.api.scala._
    +import org.apache.flink.streaming.api.watermark.Watermark
    +import org.apache.flink.streaming.api.windowing.time.Time
    +import org.apache.flink.test.util.TestBaseUtils
    +import org.junit.{After, Before, Rule, Test}
    +import org.junit.rules.TemporaryFolder
    +
    +
    +@SuppressWarnings(Array("serial")) class CEPITCase extends ScalaStreamingMultipleProgramsTestBase
{
    --- End diff --
    
    I think we should not simply copy the Java `CEPITCase` here because it will test to a
large extend what is already tested by the Java `CEPITCase`.
    
    What's more interesting to test is whether the Scala CEP can work with pure Scala types,
such as a Scala tuple or a Scala collection. 
    
    Furthermore, it would be interesting to see whether the `select` call is correctly forwarded
to the Scala function. It should not be strictly necessary to write an IT case for that. You
should be able to extract the mapper function from the `Transformation` and then simply pass
a test value into it. If you see it in the Scala function, then the forwarding should be correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message