flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...
Date Mon, 18 Apr 2016 15:00:34 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1848#discussion_r60074102
  
    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/PartitionNode.java
---
    @@ -90,13 +90,20 @@ public SemanticProperties getSemanticProperties() {
     		private final PartitionMethod pMethod;
     		private final Partitioner<?> customPartitioner;
     		private final DataDistribution distribution;
    -		
    +		private final Ordering ordering;
    +
     		public PartitionDescriptor(PartitionMethod pMethod, FieldSet pKeys, Partitioner<?>
customPartitioner, DataDistribution distribution) {
    +			this(pMethod, pKeys, null, customPartitioner, distribution);
    +		}
    +
    +		public PartitionDescriptor(PartitionMethod pMethod, FieldSet pKeys, Ordering ordering,
Partitioner<?>
    +				customPartitioner, DataDistribution distribution) {
     			super(pKeys);
    -			
    +
     			this.pMethod = pMethod;
     			this.customPartitioner = customPartitioner;
     			this.distribution = distribution;
    +			this.ordering = ordering;
    --- End diff --
    
    Can you add a check that the `ordering` is valid (number of orders == number of keys.
Order keys == keys)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message