flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpompermaier <...@git.apache.org>
Subject [GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...
Date Fri, 15 Apr 2016 09:52:59 GMT
Github user fpompermaier commented on a diff in the pull request:

    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
    @@ -119,7 +118,11 @@ private boolean isSplitConfigured() {
     		return splitColumnName != null;
    +	/** Perform initialization of the JDBC connection. Done just once per parallel task
     	private void establishConnection() throws SQLException, ClassNotFoundException {
    +		if(dbConn!=null){
    --- End diff --
    It wa just to keep the connection establishing logic in a single method..no problem for
me to move the check in the open method

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message