flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpompermaier <...@git.apache.org>
Subject [GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...
Date Thu, 14 Apr 2016 14:40:27 GMT
Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1885#discussion_r59728967
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -232,7 +255,7 @@ private void addValue(OUT reuse) throws IOException, SQLException
{
     						reuse.setField(resultSet.getInt(pos + 1), pos);
     						break;
     					case java.sql.Types.FLOAT:
    -						reuse.setField(resultSet.getDouble(pos + 1), pos);
    +						reuse.setField(resultSet.getFloat(pos + 1), pos);
    --- End diff --
    
    Ok for me..however that should be definetely well documented


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message