flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpompermaier <...@git.apache.org>
Subject [GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750) and othe...
Date Thu, 14 Apr 2016 13:01:10 GMT
Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1885#discussion_r59712089
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -363,14 +439,31 @@ public JDBCInputFormat finish() {
     			if (format.dbURL == null) {
     				throw new IllegalArgumentException("No database URL supplied");
     			}
    -			if (format.query == null) {
    +			if (format.queryTemplate == null) {
     				throw new IllegalArgumentException("No query supplied");
     			}
     			if (format.drivername == null) {
     				throw new IllegalArgumentException("No driver supplied");
     			}
    +			adjustQueryTemplateIfNecessary();
     			return format;
     		}
    +
    +		/** Try to add $CONDITIONS token automatically (at least for straightforward cases)
*/
    +		private void adjustQueryTemplateIfNecessary() {
    --- End diff --
    
    Indeed I only try to fix the query if it is a simple select (I add the WHERE clause).
Otherwise it fails (I agree that is very dangerous to try to guess where to put the $CONDITIONS
token).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message