flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2998] Support range partition compariso...
Date Mon, 11 Apr 2016 16:16:10 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r59233583
  
    --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/CoGroupGlobalPropertiesCompatibilityTest.java
---
    @@ -93,7 +95,34 @@ public int partition(Object key, int numPartitions) {
     				GlobalProperties propsRight = new GlobalProperties();
     				propsRight.setCustomPartitioned(keysRight, part);
     				
    -				assertTrue(descr.areCompatible(reqLeft, reqRight, propsLeft, propsRight));
    +				assertTrue(descr1.areCompatible(reqLeft, reqRight, propsLeft, propsRight));
    +			}
    +
    +			TestDistribution dist1 = new TestDistribution(1);
    +			TestDistribution dist2 = new TestDistribution(1);
    +			CoGroupDescriptor descr2 = new CoGroupDescriptor(keysLeft, keysRight);
    +			
    +			// test compatible range partitioning
    --- End diff --
    
    We also need tests for a range partitioning with two (or more) keys and tests for range
partitioning with different orders.
    The tests should check for compatible and incompatible partitionings.
    Same applies for the `JoinGlobalPropertiesCompatibilityTest`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message