flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...
Date Fri, 01 Apr 2016 18:09:38 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/extensions/impl/acceptPartialFunctions/OnDataSet.scala
    @@ -0,0 +1,111 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.scala.extensions.impl.acceptPartialFunctions
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.scala.{DataSet, GroupedDataSet}
    +import scala.reflect.ClassTag
    +  * Wraps a data set, allowing to use anonymous partial functions to
    +  * perform extraction of items in a tuple, case class instance or collection
    +  *
    +  * @param ds The wrapped data set
    +  * @tparam T The type of the data set items, for which the type information must be
    +  */
    +class OnDataSet[T: TypeInformation](ds: DataSet[T]) {
    --- End diff --
    I think you do not need the `TypeInformation` context bound here. Functions should never
need the implicit type info for the input (that is contained in the DataSet already), only
ever for the return type.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message