Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D486186D0 for ; Tue, 1 Mar 2016 15:19:21 +0000 (UTC) Received: (qmail 78750 invoked by uid 500); 1 Mar 2016 15:19:18 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 78707 invoked by uid 500); 1 Mar 2016 15:19:18 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 78693 invoked by uid 99); 1 Mar 2016 15:19:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 15:19:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0D4BA2C14F4 for ; Tue, 1 Mar 2016 15:19:18 +0000 (UTC) Date: Tue, 1 Mar 2016 15:19:18 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-3498) Implement TRIM, SUBSTRING as reference design for Table API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173882#comment-15173882 ] ASF GitHub Bot commented on FLINK-3498: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1747#discussion_r54580909 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala --- @@ -49,6 +49,11 @@ object ScalarFunctions { STRING_TYPE_INFO, BuiltInMethod.SUBSTRING.method) + addSqlFunctionTrim( --- End diff -- Can you briefly explain why `TRIM` cannot be handled as a generic SQL method like `SUBSTRING` and requires its own `TrimCallGenerator`? > Implement TRIM, SUBSTRING as reference design for Table API > ----------------------------------------------------------- > > Key: FLINK-3498 > URL: https://issues.apache.org/jira/browse/FLINK-3498 > Project: Flink > Issue Type: Sub-task > Components: Table API > Reporter: Timo Walther > Assignee: Timo Walther > > As described in FLINK-3497 TRIM and SUBSTRING are the first scalar functions implemented in Calcite and used in Table API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)