Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1827-flink@git.apache.org>
In-Reply-To: <git-pr-1827-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-3639] add methods for registering
 datas...
Content-Type: text/plain
Message-Id: <20160322204815.002E8DFBC8@git1-us-west.apache.org>
Date: Tue, 22 Mar 2016 20:48:14 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1827#discussion_r57066078
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/TableEnvironment.scala ---
    @@ -72,5 +74,68 @@ class TableEnvironment {
          new ScalaBatchTranslator(config).translate[T](table.relNode)
       }
     
    -}
    +  /**
    +   * Registers a DataSet under a unique name, so that it can be used in SQL queries.
    +   * The fields of the DataSet type are used to name the Table fields.
    +   * @param name the Table name
    +   * @param dataset the DataSet to register
    +   */
    +  def registerDataSet[T](name: String, dataset: DataSet[T]): Unit = {
    --- End diff --
    
    Does it make sense to have an `AbstractTableEnvironment` for the common parts of the Java and the Scala `TableEnvironment`s?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---