Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1827-flink@git.apache.org>
In-Reply-To: <git-pr-1827-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-3639] add methods for registering
 datas...
Content-Type: text/plain
Message-Id: <20160322204149.F2B64DFBC8@git1-us-west.apache.org>
Date: Tue, 22 Mar 2016 20:41:49 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1827#discussion_r57065041
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/TranslationContext.scala ---
    @@ -59,29 +64,55 @@ object TranslationContext {
           .traitDefs(ConventionTraitDef.INSTANCE)
           .build
     
    -    tabNames = Map[AbstractTable, String]()
    -
    +    tablesRegistry = Map[String, AbstractTable]()
         relBuilder = RelBuilder.create(frameworkConfig)
    -
         nameCntr.set(0)
     
       }
     
       def addDataSet(newTable: DataSetTable[_]): String = {
    --- End diff --
    
    Refactor to `registerTable(AbstractTable)` as well? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---