flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3657) Change access of DataSetUtils.countElements() to 'public'
Date Fri, 25 Mar 2016 22:58:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212547#comment-15212547

ASF GitHub Bot commented on FLINK-3657:

Github user hsaputra commented on the pull request:

    If it is on the Dataset or any extendible public APIs, I would be worried. The change
was to expose private to public without modifying existing behavior. Would be ok from my side.

> Change access of DataSetUtils.countElements() to 'public' 
> ----------------------------------------------------------
>                 Key: FLINK-3657
>                 URL: https://issues.apache.org/jira/browse/FLINK-3657
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Minor
>             Fix For: 1.0.1
> The access of DatasetUtils.countElements() is presently 'private', change that to be
'public'. We happened to be replicating the functionality in our project and realized the
method already existed in Flink.

This message was sent by Atlassian JIRA

View raw message