flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3657) Change access of DataSetUtils.countElements() to 'public'
Date Wed, 23 Mar 2016 21:29:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209210#comment-15209210

ASF GitHub Bot commented on FLINK-3657:

Github user smarthi commented on the pull request:

    Not sure as to why u think this is "way to specific", this is a very convenient feature
to have when dealing with Distributed Row Matrix (DRM) blocks for distributed Machine Learning
computations. We found ourselves 3 different variants doing the same thing and Flink happened
to have one that directly did it for Flink's datasets. Hence this PR.
    @fhueske thanks for your feedback, it would be great to have this in the planned 1.0.1
bug release. 

> Change access of DataSetUtils.countElements() to 'public' 
> ----------------------------------------------------------
>                 Key: FLINK-3657
>                 URL: https://issues.apache.org/jira/browse/FLINK-3657
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Minor
>             Fix For: 1.0.1
> The access of DatasetUtils.countElements() is presently 'private', change that to be
'public'. We happened to be replicating the functionality in our project and realized the
method already existed in Flink.

This message was sent by Atlassian JIRA

View raw message