flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment
Date Tue, 22 Mar 2016 20:48:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207264#comment-15207264
] 

ASF GitHub Bot commented on FLINK-3639:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1827#discussion_r57066078
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/TableEnvironment.scala
---
    @@ -72,5 +74,68 @@ class TableEnvironment {
          new ScalaBatchTranslator(config).translate[T](table.relNode)
       }
     
    -}
    +  /**
    +   * Registers a DataSet under a unique name, so that it can be used in SQL queries.
    +   * The fields of the DataSet type are used to name the Table fields.
    +   * @param name the Table name
    +   * @param dataset the DataSet to register
    +   */
    +  def registerDataSet[T](name: String, dataset: DataSet[T]): Unit = {
    --- End diff --
    
    Does it make sense to have an `AbstractTableEnvironment` for the common parts of the Java
and the Scala `TableEnvironment`s?


> Add methods and utilities to register DataSets and Tables in the TableEnvironment
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-3639
>                 URL: https://issues.apache.org/jira/browse/FLINK-3639
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>
> In order to make tables queryable from SQL we need to register them under a unique name
in the TableEnvironment.
> [This design document|https://docs.google.com/document/d/1sITIShmJMGegzAjGqFuwiN_iw1urwykKsLiacokxSw0/edit]
describes the proposed API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message