flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3544) ResourceManager runtime components
Date Mon, 21 Mar 2016 18:19:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204799#comment-15204799
] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r56870497
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/standalone/StandaloneResourceManager.java
---
    @@ -0,0 +1,123 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework.standalone;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.runtime.clusterframework.FlinkResourceManager;
    +import org.apache.flink.runtime.clusterframework.ApplicationStatus;
    +import org.apache.flink.runtime.clusterframework.types.ResourceID;
    +import org.apache.flink.runtime.leaderretrieval.LeaderRetrievalService;
    +
    +import java.util.Collection;
    +import java.util.UUID;
    +
    +/**
    + * A standalone implementation of the resource manager. Used when the system is started
in
    + * standalone mode (via scripts), rather than via a resource framework like YARN or Mesos.
    + */
    +public class StandaloneResourceManager extends FlinkResourceManager<ResourceID>
{
    +	
    +
    +	public StandaloneResourceManager(Configuration flinkConfig, LeaderRetrievalService leaderRetriever)
{
    +		super(0, flinkConfig, leaderRetriever);
    +	}
    +
    +	// ------------------------------------------------------------------------
    +	//  Framework specific behavior
    +	// ------------------------------------------------------------------------
    +
    +
    +	@Override
    +	protected void newJobManagerLeaderAvailable(String leaderAddress, UUID leaderSessionID)
{
    +		super.newJobManagerLeaderAvailable(leaderAddress, leaderSessionID);
    +	}
    +
    +	@Override
    +	protected void initialize() throws Exception {
    +		// nothing to initialize
    +	}
    +
    +	@Override
    +	protected void leaderUpdated() {
    +		// nothing to update
    +	}
    +
    +	@Override
    +	protected void shutdownApplication(ApplicationStatus finalStatus, String optionalDiagnostics)
{
    +	}
    +
    +	@Override
    +	protected void fatalError(String message, Throwable error) {
    +		log.error("FATAL ERROR IN RESOURCE MANAGER: " + message, error);
    +		LOG.error("Shutting down process");
    --- End diff --
    
    Yep, will change that. There is the Actor logger and the RM logger. No need to have both.


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message