flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3544) ResourceManager runtime components
Date Mon, 21 Mar 2016 18:12:25 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204787#comment-15204787
] 

ASF GitHub Bot commented on FLINK-3544:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r56869299
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/Messages.scala
---
    @@ -29,22 +29,22 @@ object Messages {
       case object Acknowledge
     
       /**
    -   * Signals that the receiver (JobManager/TaskManager) shall disconnect the sender.
    -   *
    -   * The TaskManager may send this on shutdown to let the JobManager realize the TaskManager
    -   * loss more quickly.
    -   *
    -   * The JobManager may send this message to its TaskManagers to let them clean up their
    -   * tasks that depend on the JobManager and go into a clean state.
    -   *
    -   * @param reason The reason for disconnecting, to be displayed in log and error messages.
    -   */
    -  case class Disconnect(reason: String) extends RequiresLeaderSessionID
    +    * Accessor for the case object instance, to simplify Java interoperability.
    +    *
    +    * @return The Acknowledge case object instance.
    +    */
    +  def getAcknowledge(): Acknowledge.type = Acknowledge
     
       /**
    -   * Accessor for the case object instance, to simplify Java interoperability.
    -   *
    -   * @return The Acknowledge case object instance.
    -   */
    -  def getAcknowledge(): Acknowledge.type = Acknowledge
    +    * Signals that the receiver (JobManager/TaskManager) shall disconnect the sender.
    +    *
    +    * The TaskManager may send this on shutdown to let the JobManager realize the TaskManager
    +    * loss more quickly.
    +    *
    +    * The JobManager may send this message to its TaskManagers to let them clean up their
    +    * tasks that depend on the JobManager and go into a clean state.
    +    *
    +    * @param reason The reason for disconnecting, to be displayed in log and error messages.
    +    */
    +  case class Disconnect(reason: String) extends RequiresLeaderSessionID
    --- End diff --
    
    You're right, there is no need to change the order here. I'll revert the changes.


> ResourceManager runtime components
> ----------------------------------
>
>                 Key: FLINK-3544
>                 URL: https://issues.apache.org/jira/browse/FLINK-3544
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ResourceManager
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message