flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3498) Implement TRIM, SUBSTRING as reference design for Table API
Date Tue, 01 Mar 2016 15:25:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173891#comment-15173891

ASF GitHub Bot commented on FLINK-3498:

Github user fhueske commented on the pull request:

    The changes look good. However, it still looks like quite a bit of code at various places
to add a new function. For example, why do we need a n own code generator for `TRIM`? I thought
we could leverage Calcite's build-in functions for that or is there none for `TRIM`?

> Implement TRIM, SUBSTRING as reference design for Table API
> -----------------------------------------------------------
>                 Key: FLINK-3498
>                 URL: https://issues.apache.org/jira/browse/FLINK-3498
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API
>            Reporter: Timo Walther
>            Assignee: Timo Walther
> As described in FLINK-3497 TRIM and SUBSTRING are the first scalar functions implemented
in Calcite and used in Table API.

This message was sent by Atlassian JIRA

View raw message