flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation
Date Thu, 03 Mar 2016 10:00:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177586#comment-15177586
] 

ASF GitHub Bot commented on FLINK-3474:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1746#issuecomment-191689616
  
    Hi @ChengXiangLi, you need copy this code snippet from `DataSetGroupReduce.translateToPlan()`
to `DataSetMap.translateToPlan()` to enforce `Row` as input type:
    
    ```
        expectedType match {
          case Some(typeInfo) if typeInfo.getTypeClass != classOf[Row] =>
             throw new PlanGenException("GroupReduce operations currently only support returning
Rows.")
           case _ => // ok
         }
     
         val inputDS = input.asInstanceOf[DataSetRel].translateToPlan(
           config,
           // tell the input operator that this operator currently only supports Rows as input
           Some(TypeConverter.DEFAULT_ROW_TYPE))
    ```


> Partial aggregate interface design and sort-based implementation
> ----------------------------------------------------------------
>
>                 Key: FLINK-3474
>                 URL: https://issues.apache.org/jira/browse/FLINK-3474
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API
>            Reporter: Chengxiang Li
>            Assignee: Chengxiang Li
>
> The scope of this sub task includes:
> # Partial aggregate interface.
> # Simple aggregate function implementation, such as SUM/AVG/COUNT/MIN/MAX.
> # DataSetAggregateRule which translate logical calcite aggregate node to Flink user functions.
As hash-based combiner is not available yet(see PR #1517), we would use sort-based combine
as default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message