flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1964) Rework TwitterSource to use a Properties object instead of a file path
Date Tue, 15 Mar 2016 18:12:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195840#comment-15195840
] 

ASF GitHub Bot commented on FLINK-1964:
---------------------------------------

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/1796

    [FLINK-1964] Reimplement TwitterSource

    The TwitterSource was not really usable before because it expected the user to pass the
path to a properties file, which is accessible on all worker nodes.
    Also, the Twitter example was not working because classes were missing.
    
    I reimplemented the source and removed a lot of duplicate code.
    The PR also addresses https://issues.apache.org/jira/browse/FLINK-3407

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink1964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1796
    
----

----


> Rework TwitterSource to use a Properties object instead of a file path
> ----------------------------------------------------------------------
>
>                 Key: FLINK-1964
>                 URL: https://issues.apache.org/jira/browse/FLINK-1964
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Carlos Curotto
>            Priority: Minor
>              Labels: starter
>
> The twitter connector is very hard to use on a cluster because it expects the property
file to be present on all nodes.
> It would be much easier to ask the user to pass a Properties object immediately.
> Also, the javadoc of the class stops in the middle of the sentence.
> It was not obvious to me how the two examples TwitterStreaming and TwitterTopology differ.
Also, there is a third TwitterStream example in the streaming examples.
> The documentation of the Twitter source refers to the non existent TwitterLocal class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message