flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3579 Improve String concatenation (Ram)
Date Wed, 30 Mar 2016 07:08:42 GMT
Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1821#discussion_r57844716
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/RexNodeTranslator.scala
---
    @@ -134,7 +136,13 @@ object RexNodeTranslator {
           case Plus(left, right) =>
             val l = toRexNode(left, relBuilder)
             val r = toRexNode(right, relBuilder)
    -        relBuilder.call(SqlStdOperatorTable.PLUS, l, r)
    +        if(SqlTypeName.STRING_TYPES.contains(l.getType.getSqlTypeName)) {
    --- End diff --
    
    Valid point. I thought of handling both sides. Let me check this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message