flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3579 Improve String concatenation (Ram)
Date Tue, 29 Mar 2016 10:03:55 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/RexNodeTranslator.scala
    @@ -134,7 +136,13 @@ object RexNodeTranslator {
           case Plus(left, right) =>
             val l = toRexNode(left, relBuilder)
             val r = toRexNode(right, relBuilder)
    -        relBuilder.call(SqlStdOperatorTable.PLUS, l, r)
    +        if(SqlTypeName.STRING_TYPES.contains(l.getType.getSqlTypeName)) {
    --- End diff --
    What if `r` is a String type and `l` would have to be casted to `String`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message