flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3560] [examples] Remove unchecked outpu...
Date Tue, 22 Mar 2016 08:57:27 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1752#issuecomment-199706443
  
    I don't think the examples should implement the `ProgramDescription` interface. This might
give the impression that implementing this interface is mandatory while it is a very optional
thing.
    
    I think it is not a problem that optional program parameters such as `max-iterations`
won't be printed anymore. I would expect users to look at the code anyways to understand what
is happening and there they will see the optional parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message