flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...
Date Mon, 21 Mar 2016 16:53:13 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r56856717
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/Messages.scala
---
    @@ -29,22 +29,22 @@ object Messages {
       case object Acknowledge
     
       /**
    -   * Signals that the receiver (JobManager/TaskManager) shall disconnect the sender.
    -   *
    -   * The TaskManager may send this on shutdown to let the JobManager realize the TaskManager
    -   * loss more quickly.
    -   *
    -   * The JobManager may send this message to its TaskManagers to let them clean up their
    -   * tasks that depend on the JobManager and go into a clean state.
    -   *
    -   * @param reason The reason for disconnecting, to be displayed in log and error messages.
    -   */
    -  case class Disconnect(reason: String) extends RequiresLeaderSessionID
    +    * Accessor for the case object instance, to simplify Java interoperability.
    +    *
    +    * @return The Acknowledge case object instance.
    +    */
    +  def getAcknowledge(): Acknowledge.type = Acknowledge
     
       /**
    -   * Accessor for the case object instance, to simplify Java interoperability.
    -   *
    -   * @return The Acknowledge case object instance.
    -   */
    -  def getAcknowledge(): Acknowledge.type = Acknowledge
    +    * Signals that the receiver (JobManager/TaskManager) shall disconnect the sender.
    +    *
    +    * The TaskManager may send this on shutdown to let the JobManager realize the TaskManager
    +    * loss more quickly.
    +    *
    +    * The JobManager may send this message to its TaskManagers to let them clean up their
    +    * tasks that depend on the JobManager and go into a clean state.
    +    *
    +    * @param reason The reason for disconnecting, to be displayed in log and error messages.
    +    */
    +  case class Disconnect(reason: String) extends RequiresLeaderSessionID
    --- End diff --
    
    I don't see the reason for these changes here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message