flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...
Date Thu, 17 Mar 2016 10:25:47 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r56482960
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/messages/RegisterInfoMessageListenerSuccessful.java
---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework.messages;
    +
    +import org.apache.flink.runtime.messages.RequiresLeaderSessionID;
    +
    +/**
    + * This message signals to the application client that the registration was successful.
    + */
    +public class RegisterInfoMessageListenerSuccessful implements RequiresLeaderSessionID,
java.io.Serializable {
    +
    +	private static final long serialVersionUID = 7808628311617273755L;
    +
    +	/** The singleton instance */
    +	private static final RegisterInfoMessageListenerSuccessful INSTANCE = new RegisterInfoMessageListenerSuccessful();
    +
    +	/**
    +	 * Gets the singleton instance.
    +	 * @return The singleton instance.
    +	 */
    +	public static RegisterInfoMessageListenerSuccessful get() {
    +		return INSTANCE;
    +	}
    +
    +	// ------------------------------------------------------------------------
    +
    +	/** Private constructor to prevent instantiation */
    +	private RegisterInfoMessageListenerSuccessful() {}
    +
    +	// ------------------------------------------------------------------------
    +
    +	@Override
    +	public boolean equals(Object obj) {
    +		return obj != null && obj.getClass() == RegisterInfoMessageListenerSuccessful.class;
    +	}
    +
    +	@Override
    +	public int hashCode() {
    +		return 2018741654;
    --- End diff --
    
    Sure, but it would cause more hash collisions which is not good.
    
    Btw: I was wondering why you implemented `equals` and `hashCode` only for a subset of
messages but not for all? Does not appear to be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message