flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2997] Support range partition with user...
Date Wed, 16 Mar 2016 14:34:19 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dataproperties/GlobalProperties.java
    @@ -80,9 +83,15 @@ public void setHashPartitioned(FieldList partitionedFields) {
     		this.partitioningFields = partitionedFields;
     		this.ordering = null;
    -	public void setRangePartitioned(Ordering ordering) {
    +	/**
    +	 * Set the parameters for range partition.
    +	 * 
    +	 * @param ordering Order of the partitioned fields
    +	 * @param distribution The data distribution for range partition. User can supply a
customized data distribution,
    +	 *                     also the data distribution can be null.  
    +	 */
    +	public void setRangePartitioned(Ordering ordering, DataDistribution distribution) {
    --- End diff --
    I know you've changed this part before, but could you add a `setRangePartitioned(Ordering
ordering)` method which can be used if no `DataDistribution` is provided? Would be nicer than
passing `null` everywhere.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message