flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request: Enable Table API explain and add descriptive o...
Date Mon, 14 Mar 2016 09:00:28 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1783#discussion_r55970167
  
    --- Diff: flink-libraries/flink-table/src/test/scala/resources/testFilter1.out ---
    @@ -47,8 +48,8 @@ Stage 3 : Data Source
     		Avg. Output Record Size (bytes) : (none)
     		Filter Factor : (none)
     
    -		Stage 1 : Filter
    -			content : ('a * 2) === 0
    +		Stage 1 : FlatMap
    +			content : where: (=(MOD(a, 2), 0)), select: (a, b)
    --- End diff --
    
    Should we name this `filter` instead of `where` to be compliant with the user-facing API
method names?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message