flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3428: Adds a fixed time trailing waterma...
Date Fri, 11 Mar 2016 18:29:19 GMT
Github user StephanEwen commented on the pull request:

    I think this is a useful tool. Few comments, though:
      - You can still have a negative underflow (wrap around, positive) in the watermark generation.
      - We have somehow reached the conclusion to use Guava as little as possible, potentially
getting rid of it in the future.
      - If the `extractWatermark(T, long)` and `getCurrentWatermark()` method should not be
overridden, they should probably be final.
    ### About the name
    I am not sure about the name, maybe a native speaker can chime in here. My git feeling
was that this "trailing" would be understood as "event time trails by a certain amount behind
processing time".
    I used the term "max out of orderness" in the example in the documentation for the same
case solved here: https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/streaming/event_timestamps_watermarks.html#timestamp-assigners--watermark-generators

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message