flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...
Date Fri, 11 Mar 2016 11:14:08 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r55817803
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
    @@ -366,6 +428,28 @@ abstract class FlinkMiniCluster(
       //                          Utility Methods
       // --------------------------------------------------------------------------
     
    +//  /**
    +//    * Waits for the leading ResourceManager to be registered at the JobManager
    +//    */
    +//  def waitForResourceManagerToBeRegistered(): Unit = {
    +//    waitForResourceManagerToBeRegistered(timeout)
    +//  }
    +//
    +//
    +//  def waitForResourceManagerToBeRegistered(timeout: FiniteDuration): Unit = {
    +//
    +//    future {
    +//      resourceManagerActors foreach {
    +//        list => list.foreach(rm => rm ! NotifyWhenResourceManagerRegistered)
    +//      }
    +//
    +//      rece
    +//    }
    +//
    +//    Await.ready()
    +//
    +//  }
    --- End diff --
    
    Why is this commented out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message