flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2997] Support range partition with user...
Date Thu, 10 Mar 2016 10:37:29 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1776#discussion_r55660961
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java
---
    @@ -0,0 +1,142 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.test.javaApiOperators;
    +
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.test.distribution.CustomDistribution;
    +import org.apache.flink.api.common.functions.MapPartitionFunction;
    +import org.apache.flink.api.java.DataSet;
    +import org.apache.flink.api.java.ExecutionEnvironment;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple3;
    +import org.apache.flink.api.java.utils.DataSetUtils;
    +import org.apache.flink.types.IntValue;
    +import org.apache.flink.util.Collector;
    +import org.junit.Test;
    +
    +
    +import static org.junit.Assert.assertEquals;
    +
    +
    +public class CustomDistributionITCase {
    +	
    +	@Test
    +	public void testRangeWithDistribution1() throws Exception{
    +
    +		ExecutionEnvironment env = ExecutionEnvironment.createLocalEnvironment();
    +
    +		DataSet<Tuple3<Integer, Integer, String>> input1 = env.fromElements(
    +				new Tuple3<>(1, 1, "Hi"),
    +				new Tuple3<>(1, 2, "Hello"),
    +				new Tuple3<>(1, 3, "Hello world"),
    +				new Tuple3<>(2, 4, "Hello world, how are you?"),
    +				new Tuple3<>(2, 5, "I am fine."),
    +				new Tuple3<>(3, 6, "Luke Skywalker"),
    +				new Tuple3<>(4, 7, "Comment#1"),
    +				new Tuple3<>(4, 8, "Comment#2"),
    +				new Tuple3<>(4, 9, "Comment#3"),
    +				new Tuple3<>(5, 10, "Comment#4"));
    +
    +		IntValue[][] keys = new IntValue[2][2];
    +
    +		env.setParallelism(3);
    +
    +		for (int i = 0; i < 2; i++)
    +		{
    +			for (int j = 0; j < 2; j++)
    +			{
    +				keys[i][j] = new IntValue(i + j);
    +			}
    +		}
    +
    +		CustomDistribution cd = new CustomDistribution(keys);
    +
    +		DataSet<Tuple2<IntValue, IntValue>> out1 = DataSetUtils.partitionByRange(input1.mapPartition(
    +				new MapPartitionFunction<Tuple3<Integer, Integer, String>, Tuple2<IntValue,
IntValue>>() {
    +			public void mapPartition(Iterable<Tuple3<Integer, Integer, String>> values,
Collector<Tuple2<IntValue, IntValue>> out) {
    --- End diff --
    
    A `MapFunction` would be easier. Also preparing the data sets first before applying the
`rangeByRange` would be more readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message