flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3428: Adds a fixed time trailing waterma...
Date Fri, 04 Mar 2016 11:33:20 GMT
Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala
    @@ -750,6 +750,34 @@ class DataStream[T](stream: JavaStream[T]) {
    +    * Assigns timestamps to the elements in the data stream and periodically creates
    +    * watermarks to signal event time progress.
    +    *
    +    * This method is used for cases where the programmer wants the Watermarks emitted
    +    * the stream to lag behind the maximum timestamp seen so far by a fixed period of
    +    *
    +    * For more general cases, use the general methods
    +    * [[assignTimestampsAndWatermarks(AssignerWithPeriodicWatermarks)]]
    +    * and [[assignTimestampsAndWatermarks(AssignerWithPunctuatedWatermarks)]].
    +    *
    +    * @param fixedWatermarkTrailingPeriod the fixed lag between the currently emitted
    +    *                                     watermark and the maximum timestamp seen so
    +    * @param extractor the method to extracts the timestamp from a given record.
    +    */
    +  @PublicEvolving
    +  def assignTimestampsWithAFixedPeriodTrailingWatermark(fixedWatermarkTrailingPeriod:
    --- End diff --
    Should we really add methods on DataStream for specific assigners? Seems a bit too much
and the name is terribly long. :sweat_smile: 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message