Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09FF418BFD for ; Mon, 1 Feb 2016 11:38:02 +0000 (UTC) Received: (qmail 83609 invoked by uid 500); 1 Feb 2016 11:37:40 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 83556 invoked by uid 500); 1 Feb 2016 11:37:39 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 83543 invoked by uid 99); 1 Feb 2016 11:37:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 11:37:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C4FE82C044E for ; Mon, 1 Feb 2016 11:37:39 +0000 (UTC) Date: Mon, 1 Feb 2016 11:37:39 +0000 (UTC) From: "Maximilian Michels (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-3301. --------------------------------------- Resolution: Duplicate > Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState > -------------------------------------------------------------------------- > > Key: FLINK-3301 > URL: https://issues.apache.org/jira/browse/FLINK-3301 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > > Here is related code: > {code} > public void restoreState(SerializedCheckpointData[] state) throws Exception { > synchronized (pendingCheckpoints) { > pendingCheckpoints = SerializedCheckpointData.toDeque(state, idSerializer); > {code} > When lock is held on current pendingCheckpoints field, new reference is assigned to the same field - making the synchronization ineffective. -- This message was sent by Atlassian JIRA (v6.3.4#6332)