Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 10 Feb 2016 14:51:18 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12838546.1434565429000.16018.1455115878296@Atlassian.JIRA>
In-Reply-To: <JIRA.12838546.1434565429000@Atlassian.JIRA>
References: <JIRA.12838546.1434565429000@Atlassian.JIRA>
 <JIRA.12838546.1434565429094@arcas>
Subject: [jira] [Commented] (FLINK-2237) Add hash-based Aggregation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140908#comment-15140908 ] 

ASF GitHub Bot commented on FLINK-2237:
---------------------------------------

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52466336
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java ---
    @@ -102,7 +102,7 @@ public void testCompactingHashMapPerformance() {
     			System.out.println("Starting update...");
     			start = System.currentTimeMillis();
     			while(updater.next(target) != null) {
    -				target.setValue(target.getValue()*-1);
    --- End diff --
    
    `target.getValue()` is always 0 at this point. (see the 6th paragraph in the PR opening comment)


> Add hash-based Aggregation
> --------------------------
>
>                 Key: FLINK-2237
>                 URL: https://issues.apache.org/jira/browse/FLINK-2237
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Rafiullah Momand
>            Assignee: Gabor Gevay
>            Priority: Minor
>
> Aggregation functions at the moment are implemented in a sort-based way.
> How can we implement hash based Aggregation for Flink?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)